From 1c1516362e51c87d3a1bb78321ff325435b1b3c4 Mon Sep 17 00:00:00 2001 From: yumoqing Date: Mon, 4 Mar 2024 12:40:29 +0800 Subject: [PATCH] bugfix --- bricks/bricks.js | 11 ++----- bricks/layout.js | 10 +++--- bricks/video.js | 79 +++++++++++++++++++----------------------------- bricks/widget.js | 2 +- 4 files changed, 41 insertions(+), 61 deletions(-) diff --git a/bricks/bricks.js b/bricks/bricks.js index 0051d9c..e8d6537 100755 --- a/bricks/bricks.js +++ b/bricks/bricks.js @@ -137,16 +137,11 @@ bricks.buildEventBind = function(from_widget, widget, event, desc){ } bricks.universal_handler = function(from_widget, widget, desc, event){ - debug('universal_handler() info', 'from_widget=', - from_widget, - 'widget=', widget, - 'desc=', desc, - event); var f = bricks.buildEventHandler(from_widget, desc); if (f){ return f(event); } - debug('universal_handler() error', 'from_widget=', + console.log('universal_handler() error', 'from_widget=', from_widget, 'widget=', widget, 'desc=', desc, @@ -291,7 +286,7 @@ bricks.buildRegisterFunctionHandler = function(w, target, rtdata, desc){ bricks.buildMethodHandler = function(w, target, rtdata, desc){ var f = target[desc.method]; if (! f){ - console.log('desc:', 'not exists in', target, 'w=', w); + console.log('desc:', desc, 'not exists in', target, 'w=', w); return null; } var params = {}; @@ -367,9 +362,9 @@ bricks.getWidgetById = function(id, from_widget){ el = new_el; } if (typeof(el.bricks_widget) !== 'undefined'){ - console.log('getWidgetById():', id, from_widget, el, 'widget'); return el.bricks_widget; } + console.log('********', id, 'el=', el, 'found, but not a bricks class with dom element'); return el; } diff --git a/bricks/layout.js b/bricks/layout.js index 48d8b40..9ccc7db 100755 --- a/bricks/layout.js +++ b/bricks/layout.js @@ -38,19 +38,21 @@ bricks.Layout = class extends bricks.JsWidget { } } remove_widget(w){ - delete w.parent; + w.parent = null; this.children = this.children.filter(function(item){ return item != w; }); - this.dom_element.removeChild(w.dom_element); + w.dispatch('on_parent', null); } clear_widgets(w){ + this.dom_element.replaceChildren(); for (var i=0;i - options - { - url: - } - */ - constructor(options){ - super(options); - var autoplay = ''; - if (this.opts.autoplay){ - autoplay = 'autoplay'; - } - var url = this.opts.url; - this.dom_element.innerHTML = ``; - this.video = this.dom_element.querySelector('video'); - } - toggle_play(){ - if (this.video.paused){ - this.video.play(); - } else { - this.video.pause(); - } - } - -} -bricks.Factory.register('VideoPlayer', bricks.VideoPlayer); bricks.Factory.register('Video', bricks.Video); diff --git a/bricks/widget.js b/bricks/widget.js index d046b5b..35c7af7 100755 --- a/bricks/widget.js +++ b/bricks/widget.js @@ -8,7 +8,6 @@ bricks.JsWidget = class { this.baseURI = options.baseURI; this.opts = options; this.create(); - this.dom_element.bricks_widget = this; this.opts_set_style(); if (this.opts.tooltip){ this.dom_element.tooltip = this.opts.tooltip; @@ -22,6 +21,7 @@ bricks.JsWidget = class { if (options.csses){ this.set_csses(options.csses); } + this.dom_element.bricks_widget = this; } create(){ this.dom_element = this._create('div')